Bug 130414

Summary: WebPageCreationParameters colorSpace should be MAC not COCOA
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, joepeck, mitz, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2014-03-18 12:55:31 PDT
WebPageCreationParameters colorSpace is only used by PLATFORM(MAC), but it is defined as PLATFORM(COCOA).

The only use I see is in !PLATFORM(IOS) code:

  WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm
  87:    setColorSpace(parameters.colorSpace);
Comment 1 Joseph Pecoraro 2014-03-18 12:57:54 PDT
Created attachment 227093 [details]
[PATCH] Proposed Fix
Comment 2 mitz 2014-03-18 13:02:19 PDT
Comment on attachment 227093 [details]
[PATCH] Proposed Fix

rs=me
Comment 3 Joseph Pecoraro 2014-03-18 13:05:35 PDT
Comment on attachment 227093 [details]
[PATCH] Proposed Fix

I suspect this will collide with another patch changing a line nearby. cq may not work, but lets try anyways.
Comment 4 WebKit Commit Bot 2014-03-18 13:19:08 PDT
Comment on attachment 227093 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 227093

Committed r165839: <http://trac.webkit.org/changeset/165839>
Comment 5 WebKit Commit Bot 2014-03-18 13:19:12 PDT
All reviewed patches have been landed.  Closing bug.