Bug 130412

Summary: Web Inspector: Make update-InspectorBackendCommands.rb only update legacy protocol versions
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2014-03-18 12:05:10 PDT
Now that tip of tree files are generated at build time depending on ENABLE flags, this script does not need to update ToT backend commands. It may still be useful to update the legacy protocol versions (iOS6, and iOS7) if the CodeGenerator ever changes to produce slightly different output.
Attachments
[PATCH] Proposed Fix (5.23 KB, patch)
2014-03-18 12:07 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2014-03-18 12:07:06 PDT
Created attachment 227086 [details] [PATCH] Proposed Fix shell> ./Scripts/update-LegacyInspectorBackendCommands.rb Inspector-iOS-6.0.json -> UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js Inspector-iOS-7.0.json -> UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js
WebKit Commit Bot
Comment 2 2014-03-18 13:07:54 PDT
Comment on attachment 227086 [details] [PATCH] Proposed Fix Clearing flags on attachment: 227086 Committed r165838: <http://trac.webkit.org/changeset/165838>
WebKit Commit Bot
Comment 3 2014-03-18 13:07:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.