Bug 130403
| Summary: | Visual Studio 2013 complains about implicit casts of uint8_t enums to bool | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Blaze Burg <bburg> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, ddkilzer |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Windows 7 | ||
Blaze Burg
Not sure if this is undefined behavior or if its an MSVC bug, but it sure does spam the build output.
At JSCell.h:156:
void setRemembered(bool remembered)
{
ASSERT(m_gcData == remembered ? Marked : MarkedAndRemembered);
given the following definition
enum GCData : uint8_t {
Marked = 0,
NotMarked = 1,
MarkedAndRemembered = 2,
};
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Brent Fulgham
I don't see this anymore now that we are on VS2015.