Bug 130342

Summary: Make cmake build system use WebKit2/DerivedSources.make
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: bunhere, cdumez, commit-queue, gyuyoung.kim, mathstuf, ossy, rakuco, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 130339    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2014-03-17 09:07:50 PDT
WebKit2/DerivedSources.make is the simplest one, let's try to experiment with it first.
Attachments
Patch (17.04 KB, patch)
2014-03-27 08:19 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ben Boeckel
Comment 1 2014-03-19 20:22:56 PDT
I looked into this a bit and it seems that the work of DerivedSources.cmake in WebKit2 is already done in Source/cmake/WebKitMacros.cmake:262 (generate_webkit2_message_sources).
Csaba Osztrogonác
Comment 2 2014-03-27 08:14:08 PDT
(In reply to comment #1) > I looked into this a bit and it seems that the work of DerivedSources.cmake in WebKit2 is already done in Source/cmake/WebKitMacros.cmake:262 (generate_webkit2_message_sources). You misunderstood this bug report. Now there are two different implementation of derivedsources: DerivedSources.make (used by Apple) and cmake (used by GTK and EFL). The goal is to remove this redundancy to reduce the maintenance burden. See bug130339 and the related mails on webkit-dev for details.
Csaba Osztrogonác
Comment 3 2014-03-27 08:19:22 PDT
Created attachment 227947 [details] Patch WIP patch, not ready for review, it builds only on EFL now, ...
Ben Boeckel
Comment 4 2014-03-27 09:19:41 PDT
(In reply to comment #2) > You misunderstood this bug report. Now there are two different implementation > of derivedsources: DerivedSources.make (used by Apple) and cmake (used by GTK > and EFL). The goal is to remove this redundancy to reduce the maintenance > burden. See bug130339 and the related mails on webkit-dev for details. Ah, yeah. I guess Apple doesn't use CMake due to iOS support (though CMake-generated VS files should be fine I'd expect)?
Note You need to log in before you can comment on or make changes to this bug.