| Summary: | Make cmake build system use WebKit2/DerivedSources.make | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | NEW --- | ||||||
| Severity: | Normal | CC: | bunhere, cdumez, commit-queue, gyuyoung.kim, mathstuf, ossy, rakuco, sergio | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 130339 | ||||||
| Attachments: |
|
||||||
|
Description
Csaba Osztrogonác
2014-03-17 09:07:50 PDT
I looked into this a bit and it seems that the work of DerivedSources.cmake in WebKit2 is already done in Source/cmake/WebKitMacros.cmake:262 (generate_webkit2_message_sources). (In reply to comment #1) > I looked into this a bit and it seems that the work of DerivedSources.cmake in WebKit2 is already done in Source/cmake/WebKitMacros.cmake:262 (generate_webkit2_message_sources). You misunderstood this bug report. Now there are two different implementation of derivedsources: DerivedSources.make (used by Apple) and cmake (used by GTK and EFL). The goal is to remove this redundancy to reduce the maintenance burden. See bug130339 and the related mails on webkit-dev for details. Created attachment 227947 [details]
Patch
WIP patch, not ready for review, it builds only on EFL now, ...
(In reply to comment #2) > You misunderstood this bug report. Now there are two different implementation > of derivedsources: DerivedSources.make (used by Apple) and cmake (used by GTK > and EFL). The goal is to remove this redundancy to reduce the maintenance > burden. See bug130339 and the related mails on webkit-dev for details. Ah, yeah. I guess Apple doesn't use CMake due to iOS support (though CMake-generated VS files should be fine I'd expect)? |