Bug 130342 - Make cmake build system use WebKit2/DerivedSources.make
Summary: Make cmake build system use WebKit2/DerivedSources.make
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 130339
  Show dependency treegraph
 
Reported: 2014-03-17 09:07 PDT by Csaba Osztrogonác
Modified: 2015-06-29 02:36 PDT (History)
8 users (show)

See Also:


Attachments
Patch (17.04 KB, patch)
2014-03-27 08:19 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2014-03-17 09:07:50 PDT
WebKit2/DerivedSources.make is the simplest one,
let's try to experiment with it first.
Comment 1 Ben Boeckel 2014-03-19 20:22:56 PDT
I looked into this a bit and it seems that the work of DerivedSources.cmake in WebKit2 is already done in Source/cmake/WebKitMacros.cmake:262 (generate_webkit2_message_sources).
Comment 2 Csaba Osztrogonác 2014-03-27 08:14:08 PDT
(In reply to comment #1)
> I looked into this a bit and it seems that the work of DerivedSources.cmake in WebKit2 is already done in Source/cmake/WebKitMacros.cmake:262 (generate_webkit2_message_sources).

You misunderstood this bug report. Now there are two different implementation
of derivedsources: DerivedSources.make (used by Apple) and cmake (used by GTK
and EFL). The goal is to remove this redundancy to reduce the maintenance
burden. See bug130339 and the related mails on webkit-dev for details.
Comment 3 Csaba Osztrogonác 2014-03-27 08:19:22 PDT
Created attachment 227947 [details]
Patch

WIP patch, not ready for review, it builds only on EFL now, ...
Comment 4 Ben Boeckel 2014-03-27 09:19:41 PDT
(In reply to comment #2)
> You misunderstood this bug report. Now there are two different implementation
> of derivedsources: DerivedSources.make (used by Apple) and cmake (used by GTK
> and EFL). The goal is to remove this redundancy to reduce the maintenance
> burden. See bug130339 and the related mails on webkit-dev for details.

Ah, yeah. I guess Apple doesn't use CMake due to iOS support (though CMake-generated VS files should be fine I'd expect)?