| Summary: | [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Rob Płóciennik <r.plociennik> | ||||||
| Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, gyuyoung.kim, lucas.de.marchi, ossy | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Rob Płóciennik
2014-03-17 07:41:53 PDT
Created attachment 226915 [details]
Proposed patch
How come it didn't cause build failure previously? We have used fontconfig 2.8 long time ago and there are many developers use GCC 4.8. (In reply to comment #2) > How come it didn't cause build failure previously? Perhaps this only started to occur when compiling with language standard explicitly set to C++11? The corresponding patch for GTK was just merged on Jan 21 2014 although this very issue has been detected/patched in Fontconfig at least 2 years ago. Comment on attachment 226915 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=226915&action=review As ossy said, could you show the build error log when compiling WebKit EFL with C++11 ? > Tools/ChangeLog:8 > + fontconfig-2.8.0 is not compliant with C++11 which leads to a build break This description looks redundant because bug title is almost same with description. (In reply to comment #4) > As ossy said, could you show the build error log when compiling WebKit EFL with C++11 ? Oh, right. I'm encountering the same issues as presented here: http://lists.freedesktop.org/archives/fontconfig/2012-April/003927.html Not to mention that the person that replies to that message is the same that provided the patch included in this patch and the original GTK one (9aa823564), referenced here. > This description looks redundant because bug title is almost same with description. True, updating the ChangeLog accordingly as we speak... Created attachment 227033 [details]
Proposed patch
Comment on attachment 227033 [details] Proposed patch As mentioned in bug 127283, I believe EFL port doesn't want to slip C++11 into WebKit code as well. LGTM. Comment on attachment 227033 [details] Proposed patch Clearing flags on attachment: 227033 Committed r165808: <http://trac.webkit.org/changeset/165808> All reviewed patches have been landed. Closing bug. |