Bug 130331

Summary: [CSS Blending] layerTreeAsText should dump layer's blendMode property
Product: WebKit Reporter: Ion Rosca <rosca>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kondapallykalyan, mitica, sergio, simon.fraser, WebkitBugTracker
Priority: P2 Keywords: AdobeTracked
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 95614, 130337    
Attachments:
Description Flags
path v1
none
path v2 none

Ion Rosca
Reported 2014-03-17 06:35:21 PDT
Currently layerTreeAsText doesn't provide any info on how blend mode is propagated to GraphicsLayers. There are some cases we should check if blend mode is correctly set, for example, when the blending layer has an ancestor clipping layer.
Attachments
path v1 (4.22 KB, patch)
2014-03-17 07:09 PDT, Ion Rosca 		no flags
DetailsFormatted DiffDiff
path v2 (4.30 KB, patch)
2014-03-17 07:24 PDT, Ion Rosca 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ion Rosca
Comment 1 2014-03-17 07:09:42 PDT
Created attachment 226910 [details] path v1
Mihai Tica
Comment 2 2014-03-17 07:22:58 PDT
Don't forget to proper guard the blending changes with #ifdef ENABLE(CSS_COMPOSITING) // blending code #endif
Ion Rosca
Comment 3 2014-03-17 07:24:07 PDT
Created attachment 226911 [details] path v2
WebKit Commit Bot
Comment 4 2014-03-18 01:52:26 PDT
Comment on attachment 226911 [details] path v2 Clearing flags on attachment: 226911 Committed r165804: <http://trac.webkit.org/changeset/165804>
WebKit Commit Bot
Comment 5 2014-03-18 01:52:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.