Bug 130314

Summary: Web Replay: capture and replay keyboard events
Product: WebKit Reporter: BJ Burg <bburg>
Component: WebCore Misc.Assignee: BJ Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, enrica, joepeck, kling, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 129692    
Bug Blocks:    
Attachments:
Description Flags
the patch joepeck: review+

Description BJ Burg 2014-03-16 14:15:58 PDT 
Split this off from 129395
Comment 1 BJ Burg 2014-03-21 20:36:48 PDT 
Created attachment 227530 [details]
the patch
Comment 2 WebKit Commit Bot 2014-03-21 20:37:43 PDT 
Attachment 227530 [details] did not pass style-queue:


ERROR: Source/WebCore/replay/SerializationMethods.cpp:70:  _key is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Joseph Pecoraro 2014-03-24 14:50:38 PDT 
Comment on attachment 227530 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227530&action=review

r=me

> Source/WebCore/replay/SerializationMethods.cpp:148
> +    decodedValue = textWasDecoded ? KeypressCommand(commandName, text) : KeypressCommand(commandName);

The origin os "textWasDecoded" is pretty cryptic, but I think its fine.

> Source/WebCore/replay/SerializationMethods.cpp:154
> +    PlatformKeyboardEventAppKit(const PlatformKeyboardEvent& event, bool handledByInputMethod, Vector<KeypressCommand> commands)

Nit: Vector<>& commands
Comment 4 BJ Burg 2014-03-24 16:09:58 PDT 
Comment on attachment 227530 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227530&action=review

>> Source/WebCore/replay/SerializationMethods.cpp:148
>> +    decodedValue = textWasDecoded ? KeypressCommand(commandName, text) : KeypressCommand(commandName);
> 
> The origin os "textWasDecoded" is pretty cryptic, but I think its fine.

Yeah.. not my favorite case. I decided to prepend the key name so that capitalization is consistent for single and multi-word keys.

>> Source/WebCore/replay/SerializationMethods.cpp:154
>> +    PlatformKeyboardEventAppKit(const PlatformKeyboardEvent& event, bool handledByInputMethod, Vector<KeypressCommand> commands)
> 
> Nit: Vector<>& commands

OK
Comment 5 BJ Burg 2014-03-24 17:53:11 PDT 
Committed r166212: <http://trac.webkit.org/changeset/166212>