Summary: | Use RunLoop objects through references instead of pointers | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||||
Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | benjamin, bunhere, cdumez, cmarcelo, gyuyoung.kim, kling, sergio, webkit-ews | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Zan Dobersek
2014-03-16 14:08:58 PDT
Created attachment 226859 [details]
WIP
Running through EWS.
Attachment 226859 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 30 files
If any of these errors are false positives, please file a bug against check-webkit-style.
/Volumes/Data/EWS/WebKit/Source/WTF/wtf/cf/RunLoopCF.cpp:68:14: error: member reference type 'WTF::RunLoop' is not a pointer current()->m_nestingLevel++; ~~~~~~~~~^ /Volumes/Data/EWS/WebKit/Source/WTF/wtf/cf/RunLoopCF.cpp:75:14: error: member reference type 'WTF::RunLoop' is not a pointer current()->m_nestingLevel--; ~~~~~~~~~^ Created attachment 226863 [details]
Patch
Comment on attachment 226863 [details]
Patch
/Volumes/Data/EWS/WebKit/Source/WebKit2/Platform/IPC/mac/ConnectionMac.cpp:447:28: error: member reference type 'WTF::RunLoop' is not a pointer
m_clientRunLoop->dispatch(bind(&Connection::dispatchDidReceiveInvalidMessage, this, decoder->messageReceiverName().toString(), decoder->messageName().toString()));
~~~~~~~~~~~~~~~^
r=me once you get it to build :)
Created attachment 226914 [details]
Patch for landing
Landing candidate if the EWSs process it successfully.
Comment on attachment 226914 [details] Patch for landing Clearing flags on attachment: 226914 Committed r165746: <http://trac.webkit.org/changeset/165746> All reviewed patches have been landed. Closing bug. |