Bug 130312

Summary: Use an anonymous union of std::unique_ptr members in SVGAnimatedType
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: NEW    
Severity: Normal CC: d-r, fmalita, gyuyoung.kim, pdr, schenney, sergio, webkit-ews
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review-

Zan Dobersek
Reported 2014-03-16 13:49:02 PDT
Use an anonymous union of std::unique_ptr members in SVGAnimatedType
Attachments
Patch (22.14 KB, patch)
2014-03-16 14:49 PDT, Zan Dobersek 		darin: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2014-03-16 14:49:57 PDT
Created attachment 226861 [details] Patch
Darin Adler
Comment 2 2014-03-16 19:23:59 PDT
Comment on attachment 226861 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226861&action=review > Source/WebCore/ChangeLog:10 > + Make the union in SVGAnimatedType anonymous. The members of the union are now > + std::unique_ptr objects instead of raw pointers, enabling simply moving the > + passed-in std::unique_ptr objects in create*() methods. Great idea, but looks like the Windows compiler does not support this advanced C++ feature yet. Can’t do this unless we solve this problem on Windows.
Note You need to log in before you can comment on or make changes to this bug.