Bug 130267

Summary: Begin work on the bundle parameter API
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Anders Carlsson
Reported 2014-03-14 15:48:14 PDT
Begin work on the bundle parameter API
Attachments
Patch (7.73 KB, patch)
2014-03-14 15:51 PDT, Anders Carlsson 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2014-03-14 15:51:44 PDT
Created attachment 226771 [details] Patch
mitz
Comment 2 2014-03-14 16:23:28 PDT
Comment on attachment 226771 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226771&action=review > Source/WebKit2/Shared/WebProcessCreationParameters.h:39 > + Why? > Source/WebKit2/UIProcess/mac/WebContextMac.mm:198 > + [keyedArchiver setRequiresSecureCoding:YES]; This may not compile on Mountain Lion, where -setRequiresSecureCoding: was not declared in an API header. > Source/WebKit2/UIProcess/mac/WebContextMac.mm:202 > + [keyedArchiver encodeObject:m_bundleParameters.get() forKey:@"parameters"]; > + [keyedArchiver finishEncoding]; Why not just send -encodeWithCoder: to the dictionary? Then we don’t need the @"parameters" key.
Anders Carlsson
Comment 3 2014-03-14 16:39:50 PDT
Committed r165660: <http://trac.webkit.org/changeset/165660>
Note You need to log in before you can comment on or make changes to this bug.