Bug 130267 - Begin work on the bundle parameter API
Summary: Begin work on the bundle parameter API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-14 15:48 PDT by Anders Carlsson
Modified: 2014-03-14 16:39 PDT (History)
0 users

See Also:

Attachments
Patch (7.73 KB, patch)
2014-03-14 15:51 PDT, Anders Carlsson 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-03-14 15:48:14 PDT 
Begin work on the bundle parameter API
Comment 1 Anders Carlsson 2014-03-14 15:51:44 PDT 
Created attachment 226771 [details]
Patch
Comment 2 mitz 2014-03-14 16:23:28 PDT 
Comment on attachment 226771 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226771&action=review

> Source/WebKit2/Shared/WebProcessCreationParameters.h:39
> +

Why?

> Source/WebKit2/UIProcess/mac/WebContextMac.mm:198
> +        [keyedArchiver setRequiresSecureCoding:YES];

This may not compile on Mountain Lion, where -setRequiresSecureCoding: was not declared in an API header.

> Source/WebKit2/UIProcess/mac/WebContextMac.mm:202
> +            [keyedArchiver encodeObject:m_bundleParameters.get() forKey:@"parameters"];
> +            [keyedArchiver finishEncoding];

Why not just send -encodeWithCoder: to the dictionary? Then we don’t need the @"parameters" key.
Comment 3 Anders Carlsson 2014-03-14 16:39:50 PDT 
Committed r165660: <http://trac.webkit.org/changeset/165660>