Bug 130224

Summary: Only export initializeAndGetJSCLLVMAPI from libllvmForJSC.dylib
Product: WebKit Reporter: Juergen Ributzka <juergen>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Blocker CC: fpizlo, rniwa
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch fpizlo: review+

Juergen Ributzka
Reported 2014-03-13 21:15:24 PDT
Only export initializeAndGetJSCLLVMAPI from libllvmForJSC.dylib
Attachments
Patch (3.18 KB, patch)
2014-03-13 21:19 PDT, Juergen Ributzka 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Juergen Ributzka
Comment 1 2014-03-13 21:19:23 PDT
Created attachment 226647 [details] Patch
Mark Rowe (bdash)
Comment 2 2014-03-13 21:30:50 PDT
Comment on attachment 226647 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226647&action=review > Source/JavaScriptCore/Configurations/LLVMForJSC.xcconfig:27 > // Prevent C++ standard library operator new, delete and their related exception types from being exported as weak symbols. This comment is no longer accurate.
Filip Pizlo
Comment 3 2014-03-13 21:35:36 PDT
(In reply to comment #2) > (From update of attachment 226647 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=226647&action=review > > > Source/JavaScriptCore/Configurations/LLVMForJSC.xcconfig:27 > > // Prevent C++ standard library operator new, delete and their related exception types from being exported as weak symbols. > > This comment is no longer accurate. Yup. I will remove it.
Juergen Ributzka
Comment 4 2014-03-13 21:37:40 PDT
True. I was just looking at the weak binding list for the dylib and I see these operators (new, delete) exported, but that should be correct. The dylib itself only exports the initializeAndGetJSCLLVMAPI.
Filip Pizlo
Comment 5 2014-03-13 21:48:07 PDT
Landed in http://trac.webkit.org/changeset/165600
Ryosuke Niwa
Comment 6 2014-03-13 22:13:09 PDT
Looks like this patch broke Mac builds.
Filip Pizlo
Comment 7 2014-03-13 22:13:33 PDT
(In reply to comment #6) > Looks like this patch broke Mac builds. Looking.
Filip Pizlo
Comment 8 2014-03-13 22:15:39 PDT
(In reply to comment #7) > (In reply to comment #6) > > Looks like this patch broke Mac builds. > > Looking. Oh, that's dumb. Fix coming shortly.
Filip Pizlo
Comment 9 2014-03-13 22:19:44 PDT
(In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > Looks like this patch broke Mac builds. > > > > Looking. > > Oh, that's dumb. Fix coming shortly. Should be fixed in http://trac.webkit.org/changeset/165601!
Note You need to log in before you can comment on or make changes to this bug.