Bug 130194

Summary:

Remove StyleResolver::State::m_parentNode

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, darin, kling

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	kling: review+

Description Antti Koivisto 2014-03-13 07:56:09 PDT

We just need the parent style.

Comment 1 Antti Koivisto 2014-03-13 08:15:53 PDT

Created attachment 226594 [details]
patch

Comment 2 Andreas Kling 2014-03-13 08:56:08 PDT

Comment on attachment 226594 [details]
patch

r=me! RenderStyle&!

Comment 3 Antti Koivisto 2014-03-13 11:01:35 PDT

https://trac.webkit.org/r165542

Comment 4 Darin Adler 2014-03-13 11:38:30 PDT

To fix optimized builds:

  "__ZNK7WebCore4Node11renderStyleEv", referenced from:
      __ZN7WebCore16HTMLTitleElement17textWithDirectionEv in HTMLTitleElement.o
      __ZNK7WebCore17MediaQueryMatcher16prepareEvaluatorEv in MediaQueryMatcher.o
      __ZNK7WebCore10StyleMedia11matchMediumERKN3WTF6StringE in StyleMedia.o

We need to add includes of NodeRenderStyle.h to HTMLTitleElement.cpp, MediaQueryMatcher.cpp, and StyleMedia.cpp.

Comment 5 Darin Adler 2014-03-13 11:39:17 PDT

I see, Antti did that in http://trac.webkit.org/changeset/165547

Comment 6 Benjamin Poulain 2014-03-13 12:53:52 PDT

(In reply to comment #5)
> I see, Antti did that in http://trac.webkit.org/changeset/165547

The bots are still red after r165547.

Comment 7 Antti Koivisto 2014-03-13 13:13:37 PDT

Looks like Benjamin fixed that in https://trac.webkit.org/r165561