Summary: | Remove StyleResolver::State::m_parentNode | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, darin, kling | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Antti Koivisto
2014-03-13 07:56:09 PDT
Created attachment 226594 [details]
patch
Comment on attachment 226594 [details]
patch
r=me! RenderStyle&!
To fix optimized builds: "__ZNK7WebCore4Node11renderStyleEv", referenced from: __ZN7WebCore16HTMLTitleElement17textWithDirectionEv in HTMLTitleElement.o __ZNK7WebCore17MediaQueryMatcher16prepareEvaluatorEv in MediaQueryMatcher.o __ZNK7WebCore10StyleMedia11matchMediumERKN3WTF6StringE in StyleMedia.o We need to add includes of NodeRenderStyle.h to HTMLTitleElement.cpp, MediaQueryMatcher.cpp, and StyleMedia.cpp. I see, Antti did that in http://trac.webkit.org/changeset/165547 (In reply to comment #5) > I see, Antti did that in http://trac.webkit.org/changeset/165547 The bots are still red after r165547. Looks like Benjamin fixed that in https://trac.webkit.org/r165561 |