Bug 130190

Summary:

[EFL] Add option to use separate web process for new window in MiniBrowser

Product:

WebKit

Reporter:

Krzysztof Wolanski <k.wolanski>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, lucas.de.marchi

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

130133, 149212

Bug Blocks:

Attachments:

Description	Flags
proposed patch	none
rebased patch	none
apply suggestions	none

Description Krzysztof Wolanski 2014-03-13 04:34:30 PDT

New created window (CTRL + n) will be open in separated web process.
This option is enabled by adding a flag (S/separate-process) with launching 
MiniBrowser.

Comment 1 Krzysztof Wolanski 2014-03-13 06:51:04 PDT

Created attachment 226590 [details]
proposed patch

Comment 2 Krzysztof Wolanski 2014-03-25 03:30:55 PDT

Created attachment 227737 [details]
rebased patch

Comment 3 Gyuyoung Kim 2014-03-26 01:45:21 PDT

Comment on attachment 227737 [details]
rebased patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227737&action=review

> Tools/MiniBrowser/efl/main.c:57
> +static Eina_Bool enable_separated_process = EINA_FALSE;

To be consist with existing variable name. How about using separated_process_enabled ?

> Tools/MiniBrowser/efl/main.c:1982
>      // Enable favicon database.

Please move this comment to 1987 line.

Comment 4 Krzysztof Wolanski 2014-03-26 02:31:44 PDT

Created attachment 227839 [details]
apply suggestions

Comment 5 Gyuyoung Kim 2014-04-02 03:51:19 PDT

Comment on attachment 227839 [details]
apply suggestions

LGTM. Thanks.

Comment 6 WebKit Commit Bot 2014-04-02 04:22:59 PDT

Comment on attachment 227839 [details]
apply suggestions

Clearing flags on attachment: 227839

Committed r166639: <http://trac.webkit.org/changeset/166639>

Comment 7 WebKit Commit Bot 2014-04-02 04:23:02 PDT

All reviewed patches have been landed.  Closing bug.