Summary: | allow embedders to override the definition of CRASH() | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Fisher (:fishd, Google) <fishd> | ||||
Component: | Platform | Assignee: | Darin Fisher (:fishd, Google) <fishd> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Enhancement | ||||||
Priority: | P2 | ||||||
Version: | 523.x (Safari 3) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Darin Fisher (:fishd, Google)
2007-03-08 17:37:31 PST
Created attachment 13551 [details]
patch
simple patch to make it possible for the embedder to override the meaning of CRASH()
Comment on attachment 13551 [details]
patch
Do you have a better implementation for any particular platform? The 0xbbadbeef thing is really sorta Mac-OS-X-specific.
r=me
yes, PLATFORM(WIN_OS) should call DebugBreak() or __asm {int 3}. the latter is good for x86-Linux too. |