allow embedders to override the definition of CRASH() on some platforms, dereferencing 0xbbadbeef and writing 0 is really not the most ideal way to get attention in response to an assertion failure. for example, __asm {int 3} is much nicer on the windows platform where JIT debugging can present the user with the option to continue past the assertion with the click of a button, and if you are already running in the debugger, the instruction will be treated like an ordinary breakpoint. other platforms may have other preferred ways as well.
Created attachment 13551 [details] patch simple patch to make it possible for the embedder to override the meaning of CRASH()
Comment on attachment 13551 [details] patch Do you have a better implementation for any particular platform? The 0xbbadbeef thing is really sorta Mac-OS-X-specific. r=me
yes, PLATFORM(WIN_OS) should call DebugBreak() or __asm {int 3}. the latter is good for x86-Linux too.
Landed in r20079.