Bug 130169 – [iOS] Use the window size instead of the device size to compute device-width/device-height viewport arguments

• Component: New Bugs
• Status: RESOLVED WONTFIX

[Sam Weinig]

[iOS] Use the window size instead of the device size to compute device-width/device-height viewport arguments

[Sam Weinig]

Created attachment 226564 [details]
Patch

[Benjamin Poulain]

Comment on attachment 226564 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226564&action=review

> Source/WebCore/dom/Document.cpp:2940
> +        finalizeViewportArguments(m_viewportArguments, page()->chrome().windowRect().size());

I don't think that works. The value from windowRect() will have the orientation taken into account (and the window size could be smaller than the screen size in some cases).

[Benjamin Poulain]

Comment on attachment 226564 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226564&action=review

> Source/WebCore/dom/ViewportArguments.cpp:-419
> +void finalizeViewportArguments(ViewportArguments& arguments, FloatSize screenSize)
>  {
> -    CGSize screenSize = wkGetViewportScreenSize();
> -

As a temporary workaround:
What about modifying the screenSize to make it "in portrait", then use that value to update ViewportArguments?

[Sam Weinig]

Comment on attachment 226564 [details]
Patch

Removing this. I have a better fix.