Summary: | [WebGL] WebKit1 + WebKit2 iOS clients should check load policy | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
Component: | WebGL | Assignee: | Dean Jackson <dino> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Dean Jackson
2014-03-12 15:40:25 PDT
Created attachment 226556 [details]
Patch
Comment on attachment 226556 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226556&action=review > Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h:205 > + virtual WebCore::WebGLLoadPolicy webGLPolicyForURL(const String&) const override; > + virtual WebCore::WebGLLoadPolicy resolveWebGLPolicyForURL(const String&) const override; I hope the difference between these two is explained in a comment in the base class becuase it's not obvious. > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:622 > +#if ENABLE(WEBGL) && !PLATFORM(MAC) && !PLATFORM(IOS) !PLATFORM(COCOA)? > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1767 > + return WKShouldBlockWebGL() ? WebGLBlockCreation : WebGLAllowCreation; UNUSED_PARAM() for frame and url? > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1772 > +WebCore::WebGLLoadPolicy WebPage::resolveWebGLPolicyForURL(WebFrame* frame, const String& url) > +{ > + return WKShouldBlockWebGL() ? WebGLBlockCreation : WebGLAllowCreation; Ditto. (In reply to comment #2) > !PLATFORM(COCOA)? Done. > UNUSED_PARAM() for frame and url? Just removed them. Committed r165514: <http://trac.webkit.org/changeset/165514> |