Bug 130140

Summary: BundlePageDiagnosticLoggingClient leaks every string passing through it.
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebKit2Assignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kling, mitz
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 130151    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch bfulgham: review+

Description Andreas Kling 2014-03-12 10:36:14 PDT 
<rdar://problem/15416838>
Comment 1 Andreas Kling 2014-03-12 10:45:48 PDT 
Created attachment 226527 [details]
Patch
Comment 2 Andreas Kling 2014-03-12 11:00:45 PDT 
Committed r165481: <http://trac.webkit.org/changeset/165481>
Comment 3 WebKit Commit Bot 2014-03-12 11:52:49 PDT 
Re-opened since this is blocked by bug 130151
Comment 4 mitz 2014-04-09 23:10:45 PDT 
Created attachment 229023 [details]
Patch
Comment 5 Brent Fulgham 2014-04-10 22:15:28 PDT 
Comment on attachment 229023 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229023&action=review

r=me.

> Source/WebKit2/ChangeLog:9
> +        (WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage): Donât copy the

Looks like a smart quote got into this ASCII file.
Comment 6 mitz 2014-04-10 22:24:17 PDT 
Fixed in <http://trac.webkit.org/r167113>.