Bug 130135

Summary: Layout Test fast/workers/worker-gc.html is failing
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: Tools / TestsAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: mhahnenberg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK2%20(Tests)/r165469%20(3279)/results.html
Attachments:
Description Flags
Patch none

Description Jer Noble 2014-03-12 09:21:03 PDT 
The following layout test is failing on [insert platform]

fast/workers/worker-gc.html

Probable cause:

http://trac.webkit.org/changeset/165458/
Comment 1 Mark Hahnenberg 2014-03-12 09:56:32 PDT 
Created attachment 226522 [details]
Patch
Comment 2 Mark Hahnenberg 2014-03-12 10:04:39 PDT 
Comment on attachment 226522 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226522&action=review

> Source/JavaScriptCore/ChangeLog:11
> +        so that allocators are notified when with lastChanceToFinalize. This will give them 

s/when//
Comment 3 Jer Noble 2014-03-12 10:08:31 PDT 
FYI, it looks like fast/workers/dedicated-worker-lifecycle.html also started crashing, but unhelpfully without a crash log.
Comment 4 Geoffrey Garen 2014-03-12 10:48:32 PDT 
Comment on attachment 226522 [details]
Patch

r=me
Comment 5 Mark Hahnenberg 2014-03-12 11:18:19 PDT 
Committed r165486: <http://trac.webkit.org/changeset/165486>
Comment 6 Mark Hahnenberg 2014-03-12 11:18:38 PDT 
Comment on attachment 226522 [details]
Patch

Clearing review flag.