Bug 130085

Summary: Remove Qt cruft from style checker.
Product: WebKit Reporter: László Langó <llango.u-szeged>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, glenn, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://qt-project.org/doc/qt-4.8/containers.html#the-foreach-keyword
Attachments:
Description Flags
Patch none

László Langó
Reported 2014-03-11 05:49:51 PDT
There is no 'foreach' keyword in c++. That was a Qt feature added in: http://trac.webkit.org/changeset/46113 Qt was removed from WebKit, so we should remove the checks of this keyword from check-webkit-style scripts.
Attachments
Patch (8.55 KB, patch)
2014-03-11 05:53 PDT, László Langó 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
László Langó
Comment 1 2014-03-11 05:53:15 PDT
Created attachment 226420 [details] Patch
Csaba Osztrogonác
Comment 2 2014-03-11 05:55:12 PDT
Comment on attachment 226420 [details] Patch r=me
WebKit Commit Bot
Comment 3 2014-03-11 06:32:30 PDT
Comment on attachment 226420 [details] Patch Clearing flags on attachment: 226420 Committed r165450: <http://trac.webkit.org/changeset/165450>
WebKit Commit Bot
Comment 4 2014-03-11 06:32:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.