| Summary: | Web Inspector: console error when clicking AppCache folder tree element | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||
| Component: | Web Inspector | Assignee: | Brian Burg <burg> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, timothy, webkit-bug-importer | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
BJ Burg
2014-03-10 15:05:36 PDT
Sounds like we just need to add the class to the early return in ReourceSidebarPanel._treeElementSelected. Or come up with a special function on these tree elements (isFolder()?) that we can check. Created attachment 258014 [details]
Proposed Fix
Comment on attachment 258014 [details]
Proposed Fix
This seems fine. I guess I wonder why ApplicationCacheManifestTreeElement is not a subclass of FolderTreeElement if it acts like a folder.
(In reply to comment #3) > Comment on attachment 258014 [details] > Proposed Fix > > This seems fine. I guess I wonder why ApplicationCacheManifestTreeElement is > not a subclass of FolderTreeElement if it acts like a folder. It probably should be, or we should have a content view for the appcache manifest and change what appears for each frame that uses the same manifest. But there are larger problems with our app cache support (there are no real model objects to speak of; the content view directly unpacks protocol payloads), so I'd defer on further refactoring. Comment on attachment 258014 [details] Proposed Fix Clearing flags on attachment: 258014 Committed r187872: <http://trac.webkit.org/changeset/187872> All reviewed patches have been landed. Closing bug. |