Bug 130034

Summary:

REGRESSION (r159218): FrameView::layout() should destroy TemporaryChange<LayoutPhase> before destroying Ref<FrameView>

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebCore Misc.

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer, hyatt, simon.fraser, zalan

Priority:

Keywords:

InRadar, Regression

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ap: review+

Description Daniel Bates 2014-03-10 12:26:51 PDT

We should always destroy TemporaryChange<LayoutPhase> before destroying Ref<FrameView> in FrameView::layout() so as to ensure that the FrameView exists when we restore the original layout phase value.

Comment 1 Daniel Bates 2014-03-10 12:27:04 PDT

<rdar://problem/15664288>

Comment 2 Daniel Bates 2014-03-10 12:30:34 PDT

Created attachment 226330 [details]
Patch

Comment 3 zalan 2014-03-10 12:50:50 PDT

Comment on attachment 226330 [details]
Patch

Looks good.

Comment 4 Daniel Bates 2014-03-10 12:56:49 PDT

Committed r165396: <http://trac.webkit.org/changeset/165396>