Bug 130030

Summary: writeBarrier in emitPutReplaceStub is unnecessary
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch fpizlo: review+

Mark Hahnenberg
Reported 2014-03-10 11:41:12 PDT
We already emit write barriers for each put-by-id when they're first compiled, so it's redundant to emit a write barrier as part of the repatched code.
Attachments
Patch (1.69 KB, patch)
2014-03-10 11:42 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (1.97 KB, patch)
2014-03-10 11:45 PDT, Mark Hahnenberg 		fpizlo: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2014-03-10 11:42:28 PDT
Created attachment 226321 [details] Patch
Mark Hahnenberg
Comment 2 2014-03-10 11:45:43 PDT
Created attachment 226322 [details] Patch
Mark Hahnenberg
Comment 3 2014-03-10 11:49:29 PDT
Committed r165389: <http://trac.webkit.org/changeset/165389>
Note You need to log in before you can comment on or make changes to this bug.