Summary: | Web Inspector: Consider updating to CodeMirror 4.0 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||||
Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, graouts, joepeck, jonowells, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Timothy Hatcher
2014-03-10 06:07:24 PDT
CodeMirror 4 has been released. We should do this. Created attachment 229328 [details]
[PATCH] Proposed Fix: Update to CodeMirror 4.0.
Comment on attachment 229328 [details] [PATCH] Proposed Fix: Update to CodeMirror 4.0. View in context: https://bugs.webkit.org/attachment.cgi?id=229328&action=review Looking good. Some minor issues. Also need to rebase so the patch can apply on TOT to land. > Source/WebInspectorUI/ChangeLog:219 > * Localizations/en.lproj/localizedStrings.js: > * UserInterface/Models/DOMNode.js: > * UserInterface/Views/DOMNodeDetailsSidebarPanel.js: > - * UserInterface/Views/Main.css: > + * UserInterface/Views/Main.css: > > 2014-03-28 Joseph Pecoraro <pecoraro@apple.com> > You should revert the edits to the old parts of the ChangeLog. > Source/WebInspectorUI/Scripts/update-codemirror-resources.rb:-46 > - mode/less/less.js Need to remove less.js from Main.html. Not removing it from there will break the Production build. You should also test to make sure combining the resources like Production builds do still works. Especially jsmin.py still works on the new codemirror.js. Define COMBINE_INSPECTOR_RESOURCES=YES while building to trigger this. Or hack copy-user-interface-resources.pl to always do it. > Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js:383 > - > + This whole file can be reverted. Created attachment 229337 [details]
[PATCH] Proposed Fix: Update to CodeMirror 4.0.
The production build seems to combine the assets correctly with the new CodeMirror. Comment on attachment 229337 [details] [PATCH] Proposed Fix: Update to CodeMirror 4.0. Clearing flags on attachment: 229337 Committed r167294: <http://trac.webkit.org/changeset/167294> All reviewed patches have been landed. Closing bug. |