Bug 130016

Summary: [GTK][CMAKE] gtk-doc HTML documentation is generated by default when building with CMake
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, commit-queue, gns, gyuyoung.kim, mrobinson, rakuco, sergio, zan
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Carlos Garcia Campos 2014-03-10 04:46:51 PDT
This makes every build a lot slower
Comment 1 Martin Robinson 2014-03-10 09:54:35 PDT
Created attachment 226310 [details]
Patch
Comment 2 Martin Robinson 2014-03-10 09:58:43 PDT
Comment on attachment 226310 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226310&action=review

> Source/PlatformGTK.cmake:-50
> -if (ENABLE_WEBKIT)
> -    add_dependencies(fake-docs-target WebKit)
> -endif ()
> -
> -if (ENABLE_WEBKIT2)
> -    add_dependencies(fake-docs-target WebKit2)
> -endif ()

I forgot to mention that I also removed these. They are redundant since DocumentationDependencies already includes WebKit1 and WebKit2.
Comment 3 Carlos Garcia Campos 2014-03-10 10:44:54 PDT
Comment on attachment 226310 [details]
Patch

Thanks!
Comment 4 Martin Robinson 2014-03-10 11:30:02 PDT
Comment on attachment 226310 [details]
Patch

Clearing flags on attachment: 226310

Committed r165386: <http://trac.webkit.org/changeset/165386>
Comment 5 Martin Robinson 2014-03-10 11:30:08 PDT
All reviewed patches have been landed.  Closing bug.