Bug 130016 - [GTK][CMAKE] gtk-doc HTML documentation is generated by default when building with CMake
Summary: [GTK][CMAKE] gtk-doc HTML documentation is generated by default when building...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2014-03-10 04:46 PDT by Carlos Garcia Campos
Modified: 2014-03-10 11:30 PDT (History)
8 users (show)

See Also:


Attachments
Patch (2.69 KB, patch)
2014-03-10 09:54 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2014-03-10 04:46:51 PDT
This makes every build a lot slower
Comment 1 Martin Robinson 2014-03-10 09:54:35 PDT
Created attachment 226310 [details]
Patch
Comment 2 Martin Robinson 2014-03-10 09:58:43 PDT
Comment on attachment 226310 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226310&action=review

> Source/PlatformGTK.cmake:-50
> -if (ENABLE_WEBKIT)
> -    add_dependencies(fake-docs-target WebKit)
> -endif ()
> -
> -if (ENABLE_WEBKIT2)
> -    add_dependencies(fake-docs-target WebKit2)
> -endif ()

I forgot to mention that I also removed these. They are redundant since DocumentationDependencies already includes WebKit1 and WebKit2.
Comment 3 Carlos Garcia Campos 2014-03-10 10:44:54 PDT
Comment on attachment 226310 [details]
Patch

Thanks!
Comment 4 Martin Robinson 2014-03-10 11:30:02 PDT
Comment on attachment 226310 [details]
Patch

Clearing flags on attachment: 226310

Committed r165386: <http://trac.webkit.org/changeset/165386>
Comment 5 Martin Robinson 2014-03-10 11:30:08 PDT
All reviewed patches have been landed.  Closing bug.