Bug 130003

Summary:

Start splitting CSS Selectors's pseudo types

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

allan.jensen, bunhere, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, koivisto, macpherson, menard, rakuco, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	kling: review+

Description Benjamin Poulain 2014-03-09 23:08:42 PDT

Start splitting CSS Selectors's pseudo types

Comment 1 Benjamin Poulain 2014-03-09 23:27:32 PDT

Created attachment 226282 [details]
Patch

Comment 2 Andreas Kling 2014-03-09 23:36:06 PDT

Comment on attachment 226282 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226282&action=review

Great that you are working on this!

gtk ews looks unimpressed :|

> Source/WebCore/css/CSSSelector.cpp:304
> +    case CSSSelector::PseudoNot:
> +        if (const CSSSelectorList* selectorList = selector->selectorList())
> +        str.append(selectorList->first()->selectorText());
> +        str.append(')');

Indentation is off here.

> Source/WebCore/css/CSSSelector.cpp:319
> +            if (subSelector != firstSubSelector)
> +            str.append(',');
> +            str.append(subSelector->selectorText());

And here.

Comment 3 Benjamin Poulain 2014-03-10 00:41:08 PDT

Created attachment 226284 [details]
Patch

Comment 4 Andreas Kling 2014-03-10 01:37:22 PDT

Comment on attachment 226284 [details]
Patch

r=me

Comment 5 Benjamin Poulain 2014-03-10 13:54:41 PDT

Committed r165402: <http://trac.webkit.org/changeset/165402>