Bug 130003

Summary: Start splitting CSS Selectors's pseudo types
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, bunhere, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, koivisto, macpherson, menard, rakuco, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch kling: review+

Benjamin Poulain
Reported 2014-03-09 23:08:42 PDT
Start splitting CSS Selectors's pseudo types
Attachments
Patch (54.36 KB, patch)
2014-03-09 23:27 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (58.66 KB, patch)
2014-03-10 00:41 PDT, Benjamin Poulain 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2014-03-09 23:27:32 PDT
Created attachment 226282 [details] Patch
Andreas Kling
Comment 2 2014-03-09 23:36:06 PDT
Comment on attachment 226282 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226282&action=review Great that you are working on this! gtk ews looks unimpressed :| > Source/WebCore/css/CSSSelector.cpp:304 > + case CSSSelector::PseudoNot: > + if (const CSSSelectorList* selectorList = selector->selectorList()) > + str.append(selectorList->first()->selectorText()); > + str.append(')'); Indentation is off here. > Source/WebCore/css/CSSSelector.cpp:319 > + if (subSelector != firstSubSelector) > + str.append(','); > + str.append(subSelector->selectorText()); And here.
Benjamin Poulain
Comment 3 2014-03-10 00:41:08 PDT
Created attachment 226284 [details] Patch
Andreas Kling
Comment 4 2014-03-10 01:37:22 PDT
Comment on attachment 226284 [details] Patch r=me
Benjamin Poulain
Comment 5 2014-03-10 13:54:41 PDT
Committed r165402: <http://trac.webkit.org/changeset/165402>
Note You need to log in before you can comment on or make changes to this bug.