| Summary: | Short-circuit JSGlobalObjectInspectorController when not inspecting. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||
| Component: | JavaScriptCore | Assignee: | Andreas Kling <kling> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ggaren, joepeck, kling, timothy | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Andreas Kling
2014-03-09 16:36:44 PDT
Created attachment 226261 [details]
Patch
Comment on attachment 226261 [details]
Patch
Should we check m_consoleAgent->enabled() instead? That seems a little closer to the code we're guarding.
(In reply to comment #2) > (From update of attachment 226261 [details]) > Should we check m_consoleAgent->enabled() instead? That seems a little closer to the code we're guarding. SGTM. I'll land with that change :) Committed r165357: <http://trac.webkit.org/changeset/165357> How were you actually seeing this in DYEB? Any backtrace would do. reportAPIException is supposed to be used for JSC API exceptions. If we are triggering this frequently, is it on purpose or is it something we are doing in WebCore / Browser level that triggers an exception that we could avoid? (In reply to comment #5) > How were you actually seeing this in DYEB? Any backtrace would do. Did we find out what the exception actually was? (In reply to comment #6) > (In reply to comment #5) > > How were you actually seeing this in DYEB? Any backtrace would do. > > Did we find out what the exception actually was? Nope. :| Rolled this out in <https://trac.webkit.org/r165575> since now I can't get an exception to show up anymore. |