Bug 129982

Summary: RenderElement::valueForLength() callers misuse bool parameter.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

alan
Reported 2014-03-08 17:19:38 PST
Do not pass RenderView* as bool (percentage) LayoutUnit valueForLength(const Length&, LayoutUnit maximumValue, bool roundPercentages = false) const;
Attachments
Patch (3.41 KB, patch)
2014-03-08 17:40 PST, alan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2014-03-08 17:40:07 PST
Created attachment 226242 [details] Patch
Andreas Kling
Comment 2 2014-03-08 17:41:31 PST
Comment on attachment 226242 [details] Patch Wut. r=me
WebKit Commit Bot
Comment 3 2014-03-08 18:33:10 PST
Comment on attachment 226242 [details] Patch Clearing flags on attachment: 226242 Committed r165346: <http://trac.webkit.org/changeset/165346>
WebKit Commit Bot
Comment 4 2014-03-08 18:33:12 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.