| Summary: | Change scrollOffsetForFixedPosition() to do LayoutUnit math | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | andersca, bdakin, buildbot, cmarcelo, commit-queue, dino, esprehn+autocc, glenn, jamesr, kondapallykalyan, luiz, rniwa, simon.fraser, thorton, tonikitoo, zalan | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Simon Fraser (smfr)
2014-03-08 14:44:26 PST
Created attachment 226237 [details]
Patch
Comment on attachment 226237 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226237&action=review Why do we round/floor to layout unit? > Source/WebCore/rendering/RenderBoxModelObject.cpp:1121 > + LayoutPoint absoluteContainerOffset = flooredLayoutPoint(paintContainer->localToAbsolute(FloatPoint())); round vs floor? Comment on attachment 226237 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226237&action=review Why do we round/floor to layout unit? > Source/WebCore/rendering/RenderBoxModelObject.cpp:1121 > + LayoutPoint absoluteContainerOffset = flooredLayoutPoint(paintContainer->localToAbsolute(FloatPoint())); round vs floor? Comment on attachment 226237 [details] Patch Attachment 226237 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6309407117803520 New failing tests: platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed.html Created attachment 226239 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 226523 [details]
Patch
Created attachment 226526 [details]
Patch
Looks good. Comment on attachment 226526 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226526&action=review > Source/WebCore/page/FrameView.cpp:1542 > + viewportRect.setLocation(LayoutPoint() + scrollOffsetForFixedPosition()); Just out of curiosity, why is this better than toLayoutPoint() ? |