Bug 129977

Summary: [WK2] Improve the network process low memory handler.
Product: WebKit Reporter: Andreas Kling <kling>
Component: PlatformAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, jonlee, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch darin: review+

Andreas Kling
Reported 2014-03-08 13:02:08 PST
[WK2] Improve the network process low memory handler.
Attachments
Patch (5.04 KB, patch)
2014-03-08 13:02 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch (5.20 KB, patch)
2014-03-08 13:13 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch (5.17 KB, patch)
2014-03-08 14:36 PST, Andreas Kling 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-03-08 13:02:46 PST
Created attachment 226229 [details] Patch
Andreas Kling
Comment 2 2014-03-08 13:13:56 PST
Created attachment 226230 [details] Patch
Andreas Kling
Comment 3 2014-03-08 14:36:04 PST
Created attachment 226236 [details] Patch Remove an unnecessary #include
Darin Adler
Comment 4 2014-03-08 16:34:38 PST
Comment on attachment 226236 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226236&action=review > Source/WebKit2/NetworkProcess/mac/NetworkProcessMac.mm:55 > +#if !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090 I think we should call this PLATFORM(MAC) now instead of !PLATFORM(IOS). > Source/WebKit2/NetworkProcess/mac/NetworkProcessMac.mm:120 > + UNUSED_PARAM(critical); I suggest commenting out the argument name instead of using UNUSED_PARAM, since the former will actually give a compile error if we use the thing we say we’re not using. > Source/WebKit2/NetworkProcess/mac/NetworkProcessMac.mm:123 > + RetainPtr<CFURLCacheRef> cache = adoptCF(CFURLCacheCopySharedURLCache()); > + _CFURLCachePurgeMemoryCache(cache.get()); I think you should do this as a one-liner. No need for the local.
Andreas Kling
Comment 5 2014-03-08 16:44:07 PST
Committed r165342: <http://trac.webkit.org/changeset/165342>
Jon Lee
Comment 6 2014-03-08 20:15:56 PST
This broke iOS: bug 129987
Note You need to log in before you can comment on or make changes to this bug.