Bug 129975

Summary:

TextIterator: Use StringView and references rather than pointers

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

HTML Editing

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, buildbot, commit-queue, kling, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2	none
Patch	none

Description Darin Adler 2014-03-08 11:40:24 PST

TextIterator: Use StringView and references rather than pointers

Comment 1 Darin Adler 2014-03-08 12:35:03 PST

Created attachment 226226 [details]
Patch

Comment 2 Andreas Kling 2014-03-08 13:29:27 PST

Comment on attachment 226226 [details]
Patch

This looks crashy on EWS. (I thought red EWS was supposed to at least set cq-, causing an e-mail to get sent.)

Comment 3 Darin Adler 2014-03-08 14:36:00 PST

Fixed the build error on GTK and EFL. Now looking into test failures.

Comment 4 Darin Adler 2014-03-08 22:29:53 PST

Created attachment 226250 [details]
Patch

Comment 5 Darin Adler 2014-03-08 22:31:26 PST

I was able to reproduce and fix test failures and assertion failures. All the crashes were assertion failures. I fully expect this new patch to be green on all the EWS bots.

Comment 6 Build Bot 2014-03-08 23:04:32 PST

Comment on attachment 226250 [details]
Patch

Attachment 226250 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5476168429993984

New failing tests:
dom/xhtml/level3/core/nodelookupnamespaceuri14.xhtml

Comment 7 Build Bot 2014-03-08 23:04:35 PST

Created attachment 226252 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

Comment 8 Build Bot 2014-03-09 01:37:57 PST

Comment on attachment 226250 [details]
Patch

Attachment 226250 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5195813902876672

New failing tests:
dom/xhtml/level3/core/nodelookupnamespaceuri14.xhtml

Comment 9 Build Bot 2014-03-09 01:37:59 PST

Created attachment 226256 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

Comment 10 Build Bot 2014-03-09 03:32:37 PDT

Comment on attachment 226250 [details]
Patch

Attachment 226250 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5608302561984512

New failing tests:
dom/xhtml/level3/core/nodelookupnamespaceuri14.xhtml

Comment 11 Build Bot 2014-03-09 03:32:39 PDT

Created attachment 226258 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

Comment 12 Darin Adler 2014-03-10 10:04:01 PDT

Created attachment 226312 [details]
Patch

Comment 13 Darin Adler 2014-03-10 10:06:29 PDT

The test failure that we were seeing on the EWS bots was actually a progression, not a regression; I should have updated expected results for that test, and I have now done so.

Comment 14 WebKit Commit Bot 2014-03-10 11:24:17 PDT

Comment on attachment 226312 [details]
Patch

Clearing flags on attachment: 226312

Committed r165385: <http://trac.webkit.org/changeset/165385>

Comment 15 WebKit Commit Bot 2014-03-10 11:24:20 PDT

All reviewed patches have been landed.  Closing bug.