Bug 129971

Summary:

Use std::isnan in profiler/ProfileNode.cpp to fix build failure on OpenBSD

Product:

WebKit

Reporter:

Landry Breuil <landry>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, joepeck

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ggaren: review+, commit-queue: commit-queue-

Description Landry Breuil 2014-03-08 11:15:20 PST

Build fail if using isnan() directly. Use std::isnan as it's consistent all over webkit's source code..

Comment 1 Landry Breuil 2014-03-08 11:17:26 PST

Created attachment 226219 [details]
Patch

Comment 2 Geoffrey Garen 2014-03-08 12:11:51 PST

Comment on attachment 226219 [details]
Patch

r=me

Comment 3 WebKit Commit Bot 2014-03-08 12:12:46 PST

Comment on attachment 226219 [details]
Patch

Rejecting attachment 226219 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 226219, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/5200201748840448

Comment 4 Joseph Pecoraro 2016-01-27 15:04:55 PST

Looks like this landed a long time ago.