Bug 129945

Summary: .cfi directives in LowLevelInterpreter.cpp are providing no benefit
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch mark.lam: review+

Michael Saboff
Reported 2014-03-07 17:17:09 PST
The .cfi (call frame information) directives in llint/LowLevelInterpreter.cpp currently only wrap the LLInt assembly language with .cfi_startproc and .cfi_endproc. The other .cfi unwind directives have been disabled and aren't providing any benefit.
Attachments
Patch (2.32 KB, patch)
2014-03-07 17:56 PST, Michael Saboff 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2014-03-07 17:56:11 PST
Created attachment 226194 [details] Patch
Mark Lam
Comment 2 2014-03-07 18:30:13 PST
Comment on attachment 226194 [details] Patch r=me
Michael Saboff
Comment 3 2014-03-07 19:28:05 PST
Committed r165320: <http://trac.webkit.org/changeset/165320>
Note You need to log in before you can comment on or make changes to this bug.