Bug 129938

Summary:

[iOS WebKit2] Long-press on a link shows just "Copy"

Product:

WebKit

Reporter:

Enrica Casucci <enrica>

Component:

WebKit2

Assignee:

Enrica Casucci <enrica>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

InRadar

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	benjamin: review+

Description Enrica Casucci 2014-03-07 16:52:09 PST

This happens on any link on a page.
Accidentally removed a ! when adding a FIXME comment.

<rdar://problem/16266054>

Comment 1 Enrica Casucci 2014-03-07 16:57:49 PST

Created attachment 226186 [details]
Patch

Comment 2 Benjamin Poulain 2014-03-07 17:01:22 PST

Comment on attachment 226186 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226186&action=review

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1474
> +

Blank line here.

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1481
> +            info.title = element->getAttribute(HTMLNames::titleAttr).string();

This could be a fastGetAttribute(), HTMLNames::titleAttr cannot be animated.

Comment 3 Enrica Casucci 2014-03-07 17:11:31 PST

Committed revision 165305.