Bug 129938 - [iOS WebKit2] Long-press on a link shows just "Copy"
Summary: [iOS WebKit2] Long-press on a link shows just "Copy"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-03-07 16:52 PST by Enrica Casucci
Modified: 2014-03-07 17:11 PST (History)
0 users

See Also:


Attachments
Patch (2.90 KB, patch)
2014-03-07 16:57 PST, Enrica Casucci
benjamin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2014-03-07 16:52:09 PST
This happens on any link on a page.
Accidentally removed a ! when adding a FIXME comment.

<rdar://problem/16266054>
Comment 1 Enrica Casucci 2014-03-07 16:57:49 PST
Created attachment 226186 [details]
Patch
Comment 2 Benjamin Poulain 2014-03-07 17:01:22 PST
Comment on attachment 226186 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226186&action=review

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1474
> +

Blank line here.

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1481
> +            info.title = element->getAttribute(HTMLNames::titleAttr).string();

This could be a fastGetAttribute(), HTMLNames::titleAttr cannot be animated.
Comment 3 Enrica Casucci 2014-03-07 17:11:31 PST
Committed revision 165305.