| Summary: | Revert bug 19975 | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Landry Breuil <landry> | ||||||||||
| Component: | Web Template Framework | Assignee: | Csaba Osztrogonác <ossy> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | ajacoutot, ajacoutot, benjamin, cmarcelo, commit-queue, ossy | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Other | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Landry Breuil
2014-03-07 15:06:02 PST
Created attachment 226173 [details] Revert bug 19975 seems mail.webkit.org is down.. Attachment 226173 [details] did not pass style-queue:
ERROR: Source/WTF/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 1 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 226205 [details] Revert bug 19975 Add bug URL *** Bug 129922 has been marked as a duplicate of this bug. *** *** Bug 129923 has been marked as a duplicate of this bug. *** *** Bug 129924 has been marked as a duplicate of this bug. *** *** Bug 129925 has been marked as a duplicate of this bug. *** Forgot to explain: now on openbsd the build fails without this patch because isfinite and signbit are defined twice. Comment on attachment 226205 [details] Revert bug 19975 r=me Comment on attachment 226205 [details] Revert bug 19975 Rejecting attachment 226205 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 226205, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WTF/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/4913826214445056 Hi. What's the hold for this patch? This is preventing me from building WebKit in JHBuild. Since it only impacts OpenBSD, I think it is pretty safe. Thanks :-) Created attachment 247424 [details]
Patch for landing
(In reply to comment #11) > Hi. What's the hold for this patch? This is preventing me from building > WebKit in JHBuild. Since it only impacts OpenBSD, I think it is pretty safe. > Thanks :-) The problem was that you removed this line "Reviewed by NOBODY (OOPS!).". Created attachment 247425 [details]
Patch for landing
Comment on attachment 247425 [details] Patch for landing Clearing flags on attachment: 247425 Committed r180674: <http://trac.webkit.org/changeset/180674> All reviewed patches have been landed. Closing bug. |