Bug 129927

Summary:

Revert bug 19975

Product:

WebKit

Reporter:

Landry Breuil <landry>

Component:

Web Template Framework

Assignee:

Csaba Osztrogonác <ossy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ajacoutot, ajacoutot, benjamin, cmarcelo, commit-queue, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Other

Attachments:

Description	Flags
Revert bug 19975	none
Revert bug 19975	none
Patch for landing	none
Patch for landing	none

Landry Breuil

Reported 2014-03-07 15:06:02 PST

Now that gcc 4.7 is required bug 19975 gets in the way.

Attachments
Revert bug 19975 (1.50 KB, patch) 2014-03-07 15:09 PST, Landry Breuil	no flags	Details Formatted Diff Diff
Revert bug 19975 (1.55 KB, patch) 2014-03-08 01:12 PST, Landry Breuil	no flags	Details Formatted Diff Diff
Patch for landing (1.43 KB, patch) 2015-02-26 06:27 PST, Csaba Osztrogonác	no flags	Details Formatted Diff Diff
Patch for landing (1.38 KB, patch) 2015-02-26 06:30 PST, Csaba Osztrogonác	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Landry Breuil

Comment 1 2014-03-07 15:09:24 PST

Created attachment 226173 [details] Revert bug 19975 seems mail.webkit.org is down..

WebKit Commit Bot

Comment 2 2014-03-07 15:11:18 PST

Attachment 226173 [details] did not pass style-queue: ERROR: Source/WTF/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style.

Landry Breuil

Comment 3 2014-03-08 01:12:13 PST

Created attachment 226205 [details] Revert bug 19975 Add bug URL

Landry Breuil

Comment 4 2014-03-08 01:14:32 PST

*** Bug 129922 has been marked as a duplicate of this bug. ***

Landry Breuil

Comment 5 2014-03-08 01:14:41 PST

*** Bug 129923 has been marked as a duplicate of this bug. ***

Landry Breuil

Comment 6 2014-03-08 01:14:49 PST

*** Bug 129924 has been marked as a duplicate of this bug. ***

Landry Breuil

Comment 7 2014-03-08 01:14:57 PST

*** Bug 129925 has been marked as a duplicate of this bug. ***

Landry Breuil

Comment 8 2014-03-08 01:47:42 PST

Forgot to explain: now on openbsd the build fails without this patch because isfinite and signbit are defined twice.

Andreas Kling

Comment 9 2014-03-08 13:31:08 PST

Comment on attachment 226205 [details] Revert bug 19975 r=me

WebKit Commit Bot

Comment 10 2014-03-08 13:32:49 PST

Comment on attachment 226205 [details] Revert bug 19975 Rejecting attachment 226205 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 226205, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WTF/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/4913826214445056

Antoine Jacoutot

Comment 11 2014-04-19 05:43:30 PDT

Hi. What's the hold for this patch? This is preventing me from building WebKit in JHBuild. Since it only impacts OpenBSD, I think it is pretty safe. Thanks :-)

Csaba Osztrogonác

Comment 12 2015-02-26 06:27:36 PST

Created attachment 247424 [details] Patch for landing

Csaba Osztrogonác

Comment 13 2015-02-26 06:29:02 PST

(In reply to comment #11) > Hi. What's the hold for this patch? This is preventing me from building > WebKit in JHBuild. Since it only impacts OpenBSD, I think it is pretty safe. > Thanks :-) The problem was that you removed this line "Reviewed by NOBODY (OOPS!).".

Csaba Osztrogonác

Comment 14 2015-02-26 06:30:05 PST

Created attachment 247425 [details] Patch for landing

WebKit Commit Bot

Comment 15 2015-02-26 07:21:32 PST

Comment on attachment 247425 [details] Patch for landing Clearing flags on attachment: 247425 Committed r180674: <http://trac.webkit.org/changeset/180674>

WebKit Commit Bot

Comment 16 2015-02-26 07:21:37 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.