Summary: | Add Remote Control command support to HTMLMediaElement | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||
Component: | Media | Assignee: | Jer Noble <jer.noble> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric.carlson | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Jer Noble
2014-03-07 14:59:46 PST
Created attachment 226172 [details]
Patch
Comment on attachment 226172 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226172&action=review > Source/WebCore/html/HTMLMediaElement.cpp:3059 > + } else > + setPlaybackRate(nextScanRate()); > +} Do we really want to increase the scan rate to infinity (and beyond)? > Source/WebCore/html/HTMLMediaElement.cpp:5937 > + { } // Do nothing Nit: I don't think "{ }" is necessary, won't a semi-colon work? (In reply to comment #2) > (From update of attachment 226172 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=226172&action=review > > > Source/WebCore/html/HTMLMediaElement.cpp:3059 > > + } else > > + setPlaybackRate(nextScanRate()); > > +} > > Do we really want to increase the scan rate to infinity (and beyond)? We'll max out at ScanMaximumRate (8x) inside of nextScanRate(). > > Source/WebCore/html/HTMLMediaElement.cpp:5937 > > + { } // Do nothing > > Nit: I don't think "{ }" is necessary, won't a semi-colon work? Clang++ complains about only a semicolon, and explicitly suggests "{ }" for an empty statement. Comment on attachment 226172 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226172&action=review >>> Source/WebCore/html/HTMLMediaElement.cpp:3059 >>> +} >> >> Do we really want to increase the scan rate to infinity (and beyond)? > > We'll max out at ScanMaximumRate (8x) inside of nextScanRate(). Oops, I looked right past that! Committed r165628: <http://trac.webkit.org/changeset/165628> |