Bug 129926

Summary: Add Remote Control command support to HTMLMediaElement
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: MediaAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch eric.carlson: review+

Description Jer Noble 2014-03-07 14:59:46 PST 
Add Remote Control command support to HTLMediaElement
Comment 1 Jer Noble 2014-03-07 15:04:55 PST 
Created attachment 226172 [details]
Patch
Comment 2 Eric Carlson 2014-03-13 14:37:47 PDT 
Comment on attachment 226172 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226172&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:3059
> +    } else
> +        setPlaybackRate(nextScanRate());
> +}

Do we really want to increase the scan rate to infinity (and beyond)?

> Source/WebCore/html/HTMLMediaElement.cpp:5937
> +        { } // Do nothing

Nit: I don't think "{ }" is necessary, won't a semi-colon work?
Comment 3 Jer Noble 2014-03-13 14:47:07 PDT 
(In reply to comment #2)
> (From update of attachment 226172 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=226172&action=review
> 
> > Source/WebCore/html/HTMLMediaElement.cpp:3059
> > +    } else
> > +        setPlaybackRate(nextScanRate());
> > +}
> 
> Do we really want to increase the scan rate to infinity (and beyond)?

We'll max out at ScanMaximumRate (8x) inside of nextScanRate().

> > Source/WebCore/html/HTMLMediaElement.cpp:5937
> > +        { } // Do nothing
> 
> Nit: I don't think "{ }" is necessary, won't a semi-colon work?

Clang++ complains about only a semicolon, and explicitly suggests "{ }" for an empty statement.
Comment 4 Eric Carlson 2014-03-13 16:08:33 PDT 
Comment on attachment 226172 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226172&action=review

>>> Source/WebCore/html/HTMLMediaElement.cpp:3059
>>> +}
>> 
>> Do we really want to increase the scan rate to infinity (and beyond)?
> 
> We'll max out at ScanMaximumRate (8x) inside of nextScanRate().

Oops, I looked right past that!
Comment 5 Jer Noble 2014-03-14 10:23:07 PDT 
Committed r165628: <http://trac.webkit.org/changeset/165628>