Bug 129904

Summary:

REGRESSION(165267): Broke a webkitpy unit tests

Product:

WebKit

Reporter:

Martin Robinson <mrobinson>

Component:

Tools / Tests

Assignee:

Martin Robinson <mrobinson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, glenn

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	jhoneycutt: review+

Description Martin Robinson 2014-03-07 13:06:47 PST

gtk.py used to assume that the build was an autotools build unless it could prove otherwise. Now that CMake is the default, we should assume it's a CMake build unless proven otherwise. This matters because it changes the expected results on systems where we can detect neither a CMake or an autotools build. We should assume a CMake build so that "--gtk" is used instead of "--gtkautotools" for invoking commands.

Comment 1 Martin Robinson 2014-03-07 13:09:37 PST

Created attachment 226153 [details]
Patch

Comment 2 Jon Honeycutt 2014-03-07 13:17:28 PST

Comment on attachment 226153 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226153&action=review

r=me

> Tools/Scripts/webkitpy/port/gtk.py:57
>      def _is_cmake_build(self):
> -        return os.path.exists(self._build_path('CMakeCache.txt'))
> +        return not os.path.exists(self._build_path('config.log'))

A comment about this would help readability.

Comment 3 Martin Robinson 2014-03-07 13:27:10 PST

Committed r165284: <http://trac.webkit.org/changeset/165284>