| Summary: | [iOS] Add an updateID to visibleContentRect updates which is passed back in layer transactions, so we know whether transactions are stale | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, simon.fraser, thorton | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2014-03-07 12:16:50 PST
Created attachment 226147 [details]
Patch
Comment on attachment 226147 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226147&action=review > Source/WebKit2/Shared/VisibleContentRectUpdateInfo.h:47 > + VisibleContentRectUpdateInfo(const WebCore::FloatRect& exposedRect, const WebCore::FloatRect& unobscuredRect, const WebCore::FloatRect& customFixedPositionRect, double scale, uint64_t updateID, bool inStableState) I would put the update ID first for some reason... > Source/WebKit2/Shared/VisibleContentRectUpdateInfo.h:78 > + // Note: the comparison doesn't include updateID. I agree this is correct but you should probably say why here. |