Summary: | Update the install guidelines for perf.webkit.org | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zoltan Horvath <zoltan> | ||||||||||||
Component: | Tools / Tests | Assignee: | Zoltan Horvath <zoltan> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | commit-queue | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 77037 | ||||||||||||||
Attachments: |
|
Description
Zoltan Horvath
2014-03-07 11:30:02 PST
Created attachment 226142 [details]
Patch
Created attachment 226143 [details]
Patch
Comment on attachment 226143 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226143&action=review > Websites/perf.webkit.org/Install.md:19 > +## Start Server application This sounds as if using Server app is necessary. We should emphasize that this is discouraged. > Websites/perf.webkit.org/Install.md:-26 > -## Edit /private/etc/apache2/httpd.conf > + - Enable PHP web applications > + - Go to Server Website / Store Site Files In, change it to /Volumes/Data/WebKitPerfMonitor/public/` > + - Go to Server Website / Edit advanced settings, enable Allow overrides using .htaccess files > + > +## Edit /Library/Server/Web/Config/apache2/sites/0000_any_80.conf (and/or 0000_any_443.conf) > > 1. Update ServerAdmin to your email address > -2. Change DocumentRoot to `/Volumes/Data/WebKitPerfMonitor/public/` > -3. Uncomment `"LoadModule php5_module libexec/apache2/libphp5.so"` > -4. Modify the directives for the document root and / to allow overriding `"All"` > -5. Delete directives on CGI-Executables > -6. Add the following directives to enable gzip: We should keep the old instruction for the case when you didn't start Server app. Created attachment 226320 [details]
Patch
I've updated the patch.
Comment on attachment 226320 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226320&action=review > Websites/perf.webkit.org/Install.md:39 > + Note: If you've accidentally turned on the Server app, httpd.conf is located at `/Library/Server/Web/Config/apache2/` instead. > + -Delete the Web Sharing related stuff and include `/private/etc/apache2/httpd.conf` at the very end. We can remove this now that we have a section dedicated for Server.app. > Websites/perf.webkit.org/Install.md:60 > +Hint: The apache logs are located at `/private/var/log/apache2`. I don't think "Hint:" is necessary. > Websites/perf.webkit.org/Install.md:78 > +where <Realm> is replaced with the realm of your choice. (Realm will show up on the username/password popup.) I don't what you're referring to by "popup". > Websites/perf.webkit.org/Install.md:90 > +Hint: The binaries located in /Applications/Server.app/Contents/ServerRoot/usr/bin/ I don't think we need "Hint". Just say it. > Websites/perf.webkit.org/Install.md:103 > +Hint: If you rerun the command, it will drop and reinitialize all the tables. I don't think this description is useful since the entire section is titled "Initializing the Database". Created attachment 226336 [details]
Patch
I've addressed the comments.
Created attachment 226337 [details]
Patch
Added Mavericks vs. Mountain Lion comment.
Comment on attachment 226337 [details] Patch Clearing flags on attachment: 226337 Committed r165411: <http://trac.webkit.org/changeset/165411> All reviewed patches have been landed. Closing bug. |