Bug 129895 - Update the install guidelines for perf.webkit.org
Summary: Update the install guidelines for perf.webkit.org
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zoltan Horvath
Depends on:
Blocks: 77037
  Show dependency treegraph
Reported: 2014-03-07 11:30 PST by Zoltan Horvath
Modified: 2014-03-10 15:55 PDT (History)
1 user (show)

See Also:

Patch (4.86 KB, patch)
2014-03-07 11:33 PST, Zoltan Horvath
no flags Details | Formatted Diff | Diff
Patch (4.87 KB, patch)
2014-03-07 11:34 PST, Zoltan Horvath
rniwa: review-
rniwa: commit-queue-
Details | Formatted Diff | Diff
Patch (5.85 KB, patch)
2014-03-10 11:35 PDT, Zoltan Horvath
no flags Details | Formatted Diff | Diff
Patch (5.35 KB, patch)
2014-03-10 15:00 PDT, Zoltan Horvath
no flags Details | Formatted Diff | Diff
Patch (5.46 KB, patch)
2014-03-10 15:11 PDT, Zoltan Horvath
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2014-03-07 11:30:02 PST
The current install guideline for perf.webkit.org discourages the use of the installed Server application.
I've actualized the documentation for Mavericks, and modified the guideline for using the Server app.
Comment 1 Zoltan Horvath 2014-03-07 11:33:09 PST
Created attachment 226142 [details]
Comment 2 Zoltan Horvath 2014-03-07 11:34:17 PST
Created attachment 226143 [details]
Comment 3 Ryosuke Niwa 2014-03-07 16:50:17 PST
Comment on attachment 226143 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=226143&action=review

> Websites/perf.webkit.org/Install.md:19
> +## Start Server application

This sounds as if using Server app is necessary. We should emphasize that this is discouraged.

> Websites/perf.webkit.org/Install.md:-26
> -## Edit /private/etc/apache2/httpd.conf
> + - Enable PHP web applications
> + - Go to Server Website / Store Site Files In, change it to /Volumes/Data/WebKitPerfMonitor/public/`
> + - Go to Server Website / Edit advanced settings, enable Allow overrides using .htaccess files
> +
> +## Edit /Library/Server/Web/Config/apache2/sites/0000_any_80.conf (and/or 0000_any_443.conf)
>  1. Update ServerAdmin to your email address
> -2. Change DocumentRoot to `/Volumes/Data/WebKitPerfMonitor/public/`
> -3. Uncomment `"LoadModule php5_module libexec/apache2/libphp5.so"`
> -4. Modify the directives for the document root and / to allow overriding `"All"`
> -5. Delete directives on CGI-Executables
> -6. Add the following directives to enable gzip:

We should keep the old instruction for the case when you didn't start Server app.
Comment 4 Zoltan Horvath 2014-03-10 11:35:41 PDT
Created attachment 226320 [details]

I've updated the patch.
Comment 5 Ryosuke Niwa 2014-03-10 14:53:37 PDT
Comment on attachment 226320 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=226320&action=review

> Websites/perf.webkit.org/Install.md:39
> + Note: If you've accidentally turned on the Server app, httpd.conf is located at `/Library/Server/Web/Config/apache2/` instead.
> +     -Delete the Web Sharing related stuff and include `/private/etc/apache2/httpd.conf` at the very end.

We can remove this now that we have a section dedicated for Server.app.

> Websites/perf.webkit.org/Install.md:60
> +Hint: The apache logs are located at `/private/var/log/apache2`.

I don't think "Hint:" is necessary.

> Websites/perf.webkit.org/Install.md:78
> +where <Realm> is replaced with the realm of your choice. (Realm will show up on the username/password popup.)

I don't what you're referring to by "popup".

> Websites/perf.webkit.org/Install.md:90
> +Hint: The binaries located in /Applications/Server.app/Contents/ServerRoot/usr/bin/

I don't think we need "Hint". Just say it.

> Websites/perf.webkit.org/Install.md:103
> +Hint: If you rerun the command, it will drop and reinitialize all the tables.

I don't think this description is useful since the entire section is titled "Initializing the Database".
Comment 6 Zoltan Horvath 2014-03-10 15:00:57 PDT
Created attachment 226336 [details]

I've addressed the comments.
Comment 7 Zoltan Horvath 2014-03-10 15:11:18 PDT
Created attachment 226337 [details]

Added Mavericks vs. Mountain Lion comment.
Comment 8 WebKit Commit Bot 2014-03-10 15:55:28 PDT
Comment on attachment 226337 [details]

Clearing flags on attachment: 226337

Committed r165411: <http://trac.webkit.org/changeset/165411>
Comment 9 WebKit Commit Bot 2014-03-10 15:55:30 PDT
All reviewed patches have been landed.  Closing bug.