Bug 129886

Summary: run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Severity: Normal CC: commit-queue, fpizlo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description Mark Hahnenberg 2014-03-07 08:57:44 PST
It should.
Comment 1 Mark Hahnenberg 2014-03-07 10:37:18 PST
Created attachment 226137 [details]
Comment 2 Mark Lam 2014-03-07 11:03:43 PST
Comment on attachment 226137 [details]

Comment 3 WebKit Commit Bot 2014-03-07 11:34:36 PST
Comment on attachment 226137 [details]

Clearing flags on attachment: 226137

Committed r165274: <http://trac.webkit.org/changeset/165274>
Comment 4 WebKit Commit Bot 2014-03-07 11:34:37 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Filip Pizlo 2014-03-28 13:45:05 PDT
This made all error reporting super ugly because of the way that "1>&2" was added.  Apparently when you add it without a space after the prefixCommand(), it somehow tells shell to duplicate the output.  Don't ask why.

Anyway, the moral of the story is: if you make changes to error handling in run-jsc-stress-tests you should test the error handling by locally breaking a test.

I'll fix it.