Bug 129886

Summary: run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Mark Hahnenberg
Reported 2014-03-07 08:57:44 PST
It should.
Attachments
Patch (6.46 KB, patch)
2014-03-07 10:37 PST, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2014-03-07 10:37:18 PST
Created attachment 226137 [details] Patch
Mark Lam
Comment 2 2014-03-07 11:03:43 PST
Comment on attachment 226137 [details] Patch r=me
WebKit Commit Bot
Comment 3 2014-03-07 11:34:36 PST
Comment on attachment 226137 [details] Patch Clearing flags on attachment: 226137 Committed r165274: <http://trac.webkit.org/changeset/165274>
WebKit Commit Bot
Comment 4 2014-03-07 11:34:37 PST
All reviewed patches have been landed. Closing bug.
Filip Pizlo
Comment 5 2014-03-28 13:45:05 PDT
This made all error reporting super ugly because of the way that "1>&2" was added. Apparently when you add it without a space after the prefixCommand(), it somehow tells shell to duplicate the output. Don't ask why. Anyway, the moral of the story is: if you make changes to error handling in run-jsc-stress-tests you should test the error handling by locally breaking a test. I'll fix it.
Note You need to log in before you can comment on or make changes to this bug.