Bug 129876

Summary:

Syntax error in the sandbox profile for Adobe Flash plugin

Product:

WebKit

Reporter:

Dmitry Rodionov <i.am.rodionovd>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

andersca, ap, commit-queue, eric.carlson, ggaren, glenn, ike, jer.noble, philipj, sam, scooper, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac (Intel)

OS:

OS X 10.8

Attachments:

Description	Flags
Patch fixing this bug	none
The proper patch for the bug	none
Fixed proper patch	sam: review-

Dmitry Rodionov

Reported 2014-03-07 04:07:02 PST

Syntax error in file Source/WebKit2/Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb, line 31: a regex string literal should start with a «#» (number) sign. >> 31: (home-library-regex "/Application Support/Macromedia/ss\.(cfg|cfn|sgn)$"))

Attachments
Patch fixing this bug (646 bytes, patch) 2014-03-07 04:45 PST, Dmitry Rodionov	no flags	Details Formatted Diff Diff
The proper patch for the bug (1.48 KB, patch) 2014-03-08 03:08 PST, Dmitry Rodionov	no flags	Details Formatted Diff Diff
Fixed proper patch (1.48 KB, patch) 2014-03-08 11:01 PST, Dmitry Rodionov	sam: review-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Dmitry Rodionov

Comment 1 2014-03-07 04:45:25 PST

Created attachment 226116 [details] Patch fixing this bug

Dmitry Rodionov

Comment 2 2014-03-08 03:08:35 PST

Created attachment 226212 [details] The proper patch for the bug

Geoffrey Garen

Comment 3 2014-03-08 10:48:10 PST

Comment on attachment 226212 [details] The proper patch for the bug View in context: https://bugs.webkit.org/attachment.cgi?id=226212&action=review > Source/WebKit2/ChangeLog:8 > + A regex string literal should start with a Â«#Â» (numbert) sign (line 31). Please us ASCII quotes. "numbert" should be "number".

Geoffrey Garen

Comment 4 2014-03-08 10:48:19 PST

*use

Dmitry Rodionov

Comment 5 2014-03-08 11:01:36 PST

Created attachment 226216 [details] Fixed proper patch

Dmitry Rodionov

Comment 6 2014-03-08 11:03:02 PST

(In reply to comment #3) > (From update of attachment 226212 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=226212&action=review > > > Source/WebKit2/ChangeLog:8 > > + A regex string literal should start with a Â«#Â» (numbert) sign (line 31). > > Please us ASCII quotes. > > "numbert" should be "number". Sorry for that, fixed now with the last patch @ 2014-03-08 11:01 PST

Alexey Proskuryakov

Comment 7 2014-03-08 13:37:56 PST

What is the observable consequence of this issue? Is it that we allow reading from e.g. ~/Library/Application Support/Macromedia/ss<any single character>cfg? If it's an actual syntax error, then I'm not sure how it is detected - the profile compiles successfully when loading Flash. Is the error you posted printed out by some verification tool?

Ivan Krstić

Comment 8 2014-03-09 01:04:41 PST

This is not an error.

Sam Weinig

Comment 9 2014-03-10 18:02:43 PDT

Comment on attachment 226216 [details] Fixed proper patch r-ing given Ivan's comment.

Alexey Proskuryakov

Comment 10 2014-03-18 09:29:24 PDT

(In reply to comment #8) > This is not an error. Is it a mistake that would be good to fix? It seems to me that the patch is correct, despite the report lacking a rationale.

Note You need to log in before you can comment on or make changes to this bug.