Summary: | [EFL] Modify accelerated compositing related functions in ewk_view. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hyowon Kim <hw1008.kim> | ||||
Component: | WebKit EFL | Assignee: | Hyowon Kim <hw1008.kim> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bunhere, cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, ryuan.choi, sergio | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Linux | ||||||
Bug Depends on: | 129676 | ||||||
Bug Blocks: | 79766 | ||||||
Attachments: |
|
Description
Hyowon Kim
2014-03-07 03:15:45 PST
Created attachment 226249 [details]
Patch
Comment on attachment 226249 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226249&action=review rs=me. However, someone else might wanna have a final look before landing. > Source/WebKit/efl/ewk/ewk_view.cpp:989 > + evas_object_image_size_set(priv->compositingObject.get(), w, h); It would be good if we use "width, height" instead of "w, h". Comment on attachment 226249 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226249&action=review > Source/WebKit/efl/ewk/ewk_view.cpp:987 > + if (priv->compositingObject) { Should we still use extra compositingObject ? (In reply to comment #3) > (From update of attachment 226249 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=226249&action=review > > > Source/WebKit/efl/ewk/ewk_view.cpp:987 > > + if (priv->compositingObject) { > > Should we still use extra compositingObject ? We can integrate accelerated compositing on compositingObject into smartData->backing_store in the next step. Landed at http://trac.webkit.org/changeset/165428 |