Bug 129861

Summary:

Subpixel rendering: Simple compositing container layer (isSimpleContainerCompositingLayer) paints to wrong position.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cmarcelo, commit-queue, esprehn+autocc, glenn, kondapallykalyan, luiz, noam, rniwa, sergio, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
test case	none
Patch	none
Patch	none
Patch	none
Patch	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2	none
Patch	none

Description zalan 2014-03-06 21:35:59 PST

integral pixel snapping here: RenderLayerBacking::backgroundBox(), here: GraphicsLayer::setContentsRect() and here RenderLayerBacking::updateCompositedBounds

Comment 1 zalan 2014-03-06 21:43:13 PST

Created attachment 226082 [details]
test case

Comment 2 zalan 2014-03-08 11:41:20 PST

Created attachment 226223 [details]
Patch

Comment 3 Simon Fraser (smfr) 2014-03-08 11:43:18 PST

Comment on attachment 226223 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226223&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:1612
> +    // FIXME: composited background images will be fixed together with regular images.

We don't support those yet.

Comment 4 zalan 2014-03-08 12:06:04 PST

Created attachment 226224 [details]
Patch

Comment 5 zalan 2014-03-08 12:06:18 PST

Comment on attachment 226224 [details]
Patch

EWS testing.

Comment 6 zalan 2014-03-08 12:29:28 PST

Created attachment 226225 [details]
Patch

Comment 7 zalan 2014-03-08 12:40:15 PST

Created attachment 226227 [details]
Patch

Comment 8 Build Bot 2014-03-08 13:27:44 PST

Comment on attachment 226227 [details]
Patch

Attachment 226227 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5788178476695552

New failing tests:
compositing/hidpi-simple-container-layer-on-device-pixel.html

Comment 9 Build Bot 2014-03-08 13:27:47 PST

Created attachment 226231 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

Comment 10 Build Bot 2014-03-08 13:45:36 PST

Comment on attachment 226227 [details]
Patch

Attachment 226227 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5964837997772800

New failing tests:
compositing/hidpi-simple-container-layer-on-device-pixel.html

Comment 11 Build Bot 2014-03-08 13:45:40 PST

Created attachment 226232 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

Comment 12 zalan 2014-03-08 13:48:47 PST

Created attachment 226233 [details]
Patch

Comment 13 WebKit Commit Bot 2014-03-08 16:08:13 PST

Comment on attachment 226233 [details]
Patch

Clearing flags on attachment: 226233

Committed r165341: <http://trac.webkit.org/changeset/165341>

Comment 14 WebKit Commit Bot 2014-03-08 16:08:21 PST

All reviewed patches have been landed.  Closing bug.