Bug 129841

Summary: [EME] Extend the lifetime of MediaKeySession.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, eric.carlson, esprehn+autocc, glenn, kondapallykalyan, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for Landing
none
Patch for landing none

Description Jer Noble 2014-03-06 16:02:33 PST
[EME] Extend the lifetime of MediaKeySession.
Comment 1 Jer Noble 2014-03-06 16:09:20 PST
Created attachment 226057 [details]
Patch
Comment 2 Eric Carlson 2014-03-06 19:48:46 PST
Comment on attachment 226057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226057&action=review

Is it possible to add a test for this?

> Source/WebCore/Modules/encryptedmedia/MediaKeySession.h:74
> +    virtual bool hasPendingActivity() const override { return (!isClosed() && m_keys) || m_asyncEventQueue.hasPendingEvents(); }

Nit: I think "m_keys && !isClosed()" is slightly easier to understand.
Comment 3 Jer Noble 2014-03-14 12:12:11 PDT
Created attachment 226748 [details]
Patch for Landing
Comment 4 Jer Noble 2014-03-14 12:15:42 PDT
Created attachment 226749 [details]
Patch for landing

Added missing ChangeLog.
Comment 5 Jer Noble 2014-03-14 13:13:24 PDT
Comment on attachment 226749 [details]
Patch for landing

sigh.  Clearing accidental r+ flag.
Comment 6 WebKit Commit Bot 2014-03-14 13:46:10 PDT
Comment on attachment 226749 [details]
Patch for landing

Clearing flags on attachment: 226749

Committed r165643: <http://trac.webkit.org/changeset/165643>
Comment 7 WebKit Commit Bot 2014-03-14 13:46:16 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Jer Noble 2014-04-25 10:27:12 PDT
*** Bug 109644 has been marked as a duplicate of this bug. ***