Bug 129841

Summary: [EME] Extend the lifetime of MediaKeySession.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, eric.carlson, esprehn+autocc, glenn, kondapallykalyan, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for Landing
none
Patch for landing none

Jer Noble
Reported 2014-03-06 16:02:33 PST
[EME] Extend the lifetime of MediaKeySession.
Attachments
Patch (4.71 KB, patch)
2014-03-06 16:09 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for Landing (7.28 KB, patch)
2014-03-14 12:12 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.05 KB, patch)
2014-03-14 12:15 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2014-03-06 16:09:20 PST
Created attachment 226057 [details] Patch
Eric Carlson
Comment 2 2014-03-06 19:48:46 PST
Comment on attachment 226057 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226057&action=review Is it possible to add a test for this? > Source/WebCore/Modules/encryptedmedia/MediaKeySession.h:74 > + virtual bool hasPendingActivity() const override { return (!isClosed() && m_keys) || m_asyncEventQueue.hasPendingEvents(); } Nit: I think "m_keys && !isClosed()" is slightly easier to understand.
Jer Noble
Comment 3 2014-03-14 12:12:11 PDT
Created attachment 226748 [details] Patch for Landing
Jer Noble
Comment 4 2014-03-14 12:15:42 PDT
Created attachment 226749 [details] Patch for landing Added missing ChangeLog.
Jer Noble
Comment 5 2014-03-14 13:13:24 PDT
Comment on attachment 226749 [details] Patch for landing sigh. Clearing accidental r+ flag.
WebKit Commit Bot
Comment 6 2014-03-14 13:46:10 PDT
Comment on attachment 226749 [details] Patch for landing Clearing flags on attachment: 226749 Committed r165643: <http://trac.webkit.org/changeset/165643>
WebKit Commit Bot
Comment 7 2014-03-14 13:46:16 PDT
All reviewed patches have been landed. Closing bug.
Jer Noble
Comment 8 2014-04-25 10:27:12 PDT
*** Bug 109644 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.