Summary: | [EME] Extend the lifetime of MediaKeySession. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||
Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, eric.carlson, esprehn+autocc, glenn, kondapallykalyan, philipj, sergio | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Jer Noble
2014-03-06 16:02:33 PST
Created attachment 226057 [details]
Patch
Comment on attachment 226057 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226057&action=review Is it possible to add a test for this? > Source/WebCore/Modules/encryptedmedia/MediaKeySession.h:74 > + virtual bool hasPendingActivity() const override { return (!isClosed() && m_keys) || m_asyncEventQueue.hasPendingEvents(); } Nit: I think "m_keys && !isClosed()" is slightly easier to understand. Created attachment 226748 [details]
Patch for Landing
Created attachment 226749 [details]
Patch for landing
Added missing ChangeLog.
Comment on attachment 226749 [details]
Patch for landing
sigh. Clearing accidental r+ flag.
Comment on attachment 226749 [details] Patch for landing Clearing flags on attachment: 226749 Committed r165643: <http://trac.webkit.org/changeset/165643> All reviewed patches have been landed. Closing bug. *** Bug 109644 has been marked as a duplicate of this bug. *** |