Bug 129825

Summary: [CSS Shapes] inset args and radial args should serialize to the simplest form
Product: WebKit Reporter: Rebecca Hauck <rhauck>
Component: CSSAssignee: Bear Travis <betravis>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, macpherson, menard, rniwa, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 98664    
Attachments:
Description Flags
Test case for bug
none
Patch
none
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion
none
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2
none
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion
none
Updated patch none

Rebecca Hauck
Reported 2014-03-06 14:08:14 PST
From Section 3.3 of the spec: http://dev.w3.org/csswg/css-shapes/#basic-shape-serialization To serialize the <basic-shape> functions, serialize as per their individual grammars, in the order the grammars are written in, avoiding calc() expressions where possible, avoiding calc() transformations, omitting components when possible without changing the meaning, joining space-separated tokens with a single space, and following each serialized comma with a single space. The attached tests has 2 examples of inset() serialization: ---------------------------- value: inset(10px) actual: inset(10px 10px 10px 10px) expected: inset(10px) ----------------------------- value: inset(10px round 20px) actual: inset(10px 10px 10px 10px round 20px 20px 20px 20px / 20px 20px 20px 20px) expected: inset(10px round 20px) ----------------------------- Note: This uses testharness.js and the relative path in the test assumes the test is run from LayoutTests/fast/shapes/parsing
Attachments
Test case for bug (1.10 KB, text/html)
2014-03-06 14:09 PST, Rebecca Hauck 		no flags
Details
Patch (41.51 KB, patch)
2014-04-09 17:41 PDT, Bear Travis 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (490.55 KB, application/zip)
2014-04-09 18:59 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (547.31 KB, application/zip)
2014-04-09 19:08 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (544.97 KB, application/zip)
2014-04-09 19:12 PDT, Build Bot 		no flags
Details
Updated patch (43.57 KB, patch)
2014-04-10 13:31 PDT, Bear Travis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rebecca Hauck
Comment 1 2014-03-06 14:09:39 PST
Created attachment 226037 [details] Test case for bug
Zoltan Horvath
Comment 2 2014-04-03 08:53:46 PDT
Rob is started to work on this bug in Blink: https://code.google.com/p/chromium/issues/detail?id=350092 Let's wait for him, then we can port the patch over to WebKit.
Bear Travis
Comment 3 2014-04-09 17:41:34 PDT
Created attachment 229004 [details] Patch
Build Bot
Comment 4 2014-04-09 18:59:43 PDT
Comment on attachment 229004 [details] Patch Attachment 229004 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4906653015080960 New failing tests: css3/masking/clip-path-animation.html
Build Bot
Comment 5 2014-04-09 18:59:46 PDT
Created attachment 229013 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 6 2014-04-09 19:07:59 PDT
Comment on attachment 229004 [details] Patch Attachment 229004 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5646063847342080 New failing tests: css3/masking/clip-path-animation.html
Build Bot
Comment 7 2014-04-09 19:08:05 PDT
Created attachment 229014 [details] Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Build Bot
Comment 8 2014-04-09 19:11:58 PDT
Comment on attachment 229004 [details] Patch Attachment 229004 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4737813689925632 New failing tests: css3/masking/clip-path-animation.html
Build Bot
Comment 9 2014-04-09 19:12:04 PDT
Created attachment 229015 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Bear Travis
Comment 10 2014-04-10 13:31:28 PDT
Created attachment 229074 [details] Updated patch
Dirk Schulze
Comment 11 2014-04-11 09:19:13 PDT
Comment on attachment 229074 [details] Updated patch r=me
WebKit Commit Bot
Comment 12 2014-04-11 10:09:47 PDT
Comment on attachment 229074 [details] Updated patch Clearing flags on attachment: 229074 Committed r167132: <http://trac.webkit.org/changeset/167132>
WebKit Commit Bot
Comment 13 2014-04-11 10:09:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.